After years of this we have each developed a few tricks to find problematic areas when reviewing our first pull request on a legacy codebase. And so I present to you an unexplained, incomplete, and arbitrarily grouped list of keywords that will cause us to read your Rails code more with more care and suspicion.
None of these are wrong, but all of them are noteworthy.
ActiveRecord::Base#update_attributeswithout checking the return value,
- assigning to an instance variable outside of