How to Skim a Pull Request

Mike Burns

We review quite a few code diffs; it is our job. Often, when jumping on a new project, we start by reviewing pull requests.

After years of this we have each developed a few tricks to find problematic areas when reviewing our first pull request on a legacy codebase. And so I present to you an unexplained, incomplete, and arbitrarily grouped list of keywords that will cause us to read your Rails code more with more care and suspicion.

None of these are wrong, but all of them are noteworthy.

The times, they are a-changin’

They walked in line

We are the world

Generals and majors